Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor PreviewGroup #48

Merged
merged 12 commits into from
Dec 16, 2020
Merged

fix: refactor PreviewGroup #48

merged 12 commits into from
Dec 16, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Dec 8, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Dec 8, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/rdqt3zgi1
✅ Preview: https://image-git-fix-group-index.react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #48 (50a5b35) into master (f2af8e6) will increase coverage by 6.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #48      +/-   ##
===========================================
+ Coverage   93.02%   100.00%   +6.97%     
===========================================
  Files           6         5       -1     
  Lines         215       206       -9     
  Branches       57        54       -3     
===========================================
+ Hits          200       206       +6     
+ Misses         15         0      -15
Impacted Files Coverage Δ
src/Image.tsx 100.00% <100.00%> (+2.85%) ⬆️
src/Preview.tsx 100.00% <100.00%> (+11.90%) ⬆️
src/PreviewGroup.tsx 100.00% <100.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2af8e6...50a5b35. Read the comment docs.

@shaodahong shaodahong changed the title fix: PreviewGroup index [WIP] fix: refactor PreviewGroup Dec 8, 2020
@shaodahong shaodahong changed the title [WIP] fix: refactor PreviewGroup fix: refactor PreviewGroup Dec 8, 2020
@shaodahong shaodahong requested a review from zombieJ December 9, 2020 02:20
@shaodahong shaodahong mentioned this pull request Dec 9, 2020
Closed
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@shaodahong shaodahong mentioned this pull request Dec 15, 2020
Closed
1 task
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/Image.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/Image.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/Preview.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/Preview.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Dec 15, 2020
View reviewed changes
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Dec 16, 2020
View reviewed changes
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@shaodahong shaodahong merged commit fe37538 into master Dec 16, 2020
@shaodahong shaodahong deleted the fix-group-index branch December 16, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shaodahong @zombieJ